New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Use Dialog field for Modal_Contact #42326
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
This Pull Request can't be tested by Patchtester
PR-5.1-dev
labels
Nov 9, 2023
sandewt
reviewed
Nov 10, 2023
administrator/components/com_contact/layouts/joomla/form/field/modal-select/extra-buttons.php
Show resolved
Hide resolved
I have tested this item ✅ successfully on 7b694c1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42326. |
1 similar comment
I have tested this item ✅ successfully on 7b694c1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42326. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42326. |
Thank you @Fedik ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Changing
Modal_Contact
field to use new modal dialog.The same as #40462 but for Contact.
Testing Instructions
Run
npm install
.Create a menu for Contact item,
Select/edit value in "Choose a Contact" field.
Edit an Article and use insert Contact button.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
Reference: