Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Use Dialog field for Modal_Contact #42326

Merged
merged 8 commits into from Nov 14, 2023

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Nov 9, 2023

Summary of Changes

Changing Modal_Contact field to use new modal dialog.
The same as #40462 but for Contact.

Testing Instructions

Run npm install.

Create a menu for Contact item,
Select/edit value in "Choose a Contact" field.

Edit an Article and use insert Contact button.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

Reference:

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Nov 9, 2023
@Fedik Fedik added the Feature label Nov 9, 2023
@Quy
Copy link
Contributor

Quy commented Nov 11, 2023

I have tested this item ✅ successfully on 7b694c1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42326.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 7b694c1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42326.

@Quy
Copy link
Contributor

Quy commented Nov 11, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42326.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 11, 2023
@LadySolveig LadySolveig merged commit 7d04c34 into joomla:5.1-dev Nov 14, 2023
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 14, 2023
@LadySolveig
Copy link
Contributor

Thank you @Fedik !
And thanks for testing @viocassel @Quy

@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Nov 14, 2023
@Fedik Fedik deleted the popup-field-contact branch November 14, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants