Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Revert TinyMCE builder dark skin #42392

Merged
merged 1 commit into from Nov 24, 2023
Merged

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Nov 23, 2023

Pull Request for Issue #42378 .

Summary of Changes

Revert TinyMCE builder dark skin, for now,

Testing Instructions

disable darkmode
open options of TinyMCE plugin

Actual result BEFORE applying this Pull Request

TinyMCE is displayed with dark skin

Expected result AFTER applying this Pull Request

TinyMCE is display with light skin

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

Reference:

@obuisard
Copy link
Contributor

Looks like the actual/expected results are reversed, are they Fedir @Fedik ?

@Fedik
Copy link
Member Author

Fedik commented Nov 23, 2023

Thanks for note, I have fixed the description 😉

@obuisard
Copy link
Contributor

I have tested this item ✅ successfully on 11b6be8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42392.

@toivo
Copy link
Contributor

toivo commented Nov 24, 2023

I have tested this item ✅ successfully on 11b6be8

Tested succcessfully in Joomla 5.0.1-rc2-dev of 24 November using PHP 8.2.12 in Wampserver 3.3.1 on Windows 11.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42392.

@Quy
Copy link
Contributor

Quy commented Nov 24, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42392.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 24, 2023
@bembelimen bembelimen merged commit e10c050 into joomla:5.0-dev Nov 24, 2023
4 checks passed
@bembelimen
Copy link
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 24, 2023
@bembelimen bembelimen added this to the Joomla! 5.0.1 milestone Nov 24, 2023
@Fedik Fedik deleted the fix42378 branch November 24, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants