[5.x] Drop postcss, own package #42427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
dgrammatiko
force-pushed
the
5.0-dev-postcss
branch
4 times, most recently
from
2659438
to
ed987cf
Compare
dgrammatiko
force-pushed
the
5.0-dev-postcss
branch
from
ed987cf
to
84796bb
Compare
|
I have tested this item ✅ successfully on 84796bb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42427. |
|
I have tested this item ✅ successfully on 84796bb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42427. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42427. |
laoneo
reviewed
Jan 16, 2024
|
Thank you @dgrammatiko and also for testing @MacJoom @viocassel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
postcsspostcss-url-versionand replace it with an alter version of @dgrammatiko/lightningcss-url-version which does exactly the same versioning of the urls but based on LightningCSSTesting Instructions
Needs CLI commands
Before applying this PR:
npm inpm run cssversioningmediafolder somewhere in your HDD outside of the repoApply the PR
npm inpm run cssversioningmediafolder with the one saved previouslyActual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed