[5.1] HTML Mail template images #42448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quy
reviewed
Dec 3, 2023
|
I have tested this item ✅ successfully on 9e627d1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42448. |
1 similar comment
|
I have tested this item ✅ successfully on 9e627d1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42448. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42448. |
|
Thank you @brianteeman and also for testing and review @paternax @fgsw @Quy |
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue ##40678 .
Summary of Changes
When sending html mails created with com_mails it is possible to include images.
The function convertRelativeToAbsoluteUrls ensures that the images have absolute references so that they will be loaded in the email. However if the image has been added to the email using the media manager it will include loading="lazy" and data-path=
This pr strips any references to loading and data-path
https://www.caniemail.com/search/?s=loading
Testing Instructions
Set the mail templates to use html
Add an image to one of the mail templates - i suggest the Global Configuration: Test Mail
Trigger the mail and check it
Actual result BEFORE applying this Pull Request
The code for the image in the email will be
<img src="https://j5.test/images/9.webp" width="1141" height="720" loading="lazy" data-path="local-images:/9.webp">Expected result AFTER applying this Pull Request
The code for the image in the email will be
<img src="https://j5.test/images/9.webp" width="1141" height="720">The originakl issue report was classified as a bug therefore it should be 5.0 but it seems more like a feature so I made it against 5.1 but happy to change that.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed