[5.0] Tags: Add rebuild button to toolbar #42586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on 1c7f4b5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42586. |
|
I have tested this item ✅ successfully on 1c7f4b5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42586. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42586. |
|
New feature => 5.1 |
|
tested succsessvully This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42586. |
|
I have tested this item ✅ successfully on 3d4f0d6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42586. |
|
Thank you for the quick fix @Hackwar and for the tests @toivo @viocassel @CCMLanger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
On Facebook a user had an issue with invalid lft and rgt values in the tags table. When I told him to click "rebuild", it turns out that the tags component doesn't have that button. Upon adding it back in, it turns out that exactly only this button is missing, but the task in the controller and all other necessary code (even including the language strings) is already there. That is why I'm putting this PR against 5.0-dev as a bugfix and not a new feature against 5.1-dev. The code is there, the only thing missing right now is the button in the toolbar.
CC @brianteeman just to let you know that this issue would be fixed with this PR.
Testing Instructions
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed