Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Use Dialog for scheduler task "Run test" #42746

Merged
merged 1 commit into from Feb 2, 2024

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Feb 2, 2024

Summary of Changes

Use Dialog for scheduler task run

Testing Instructions

Run npm install
Go to "Scheduled Tasks" page, and run any existing task.

Actual result BEFORE applying this Pull Request

Works with BS Modal

Expected result AFTER applying this Pull Request

Works with Joomla Dialog

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

References:

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Feb 2, 2024
@Fedik Fedik added the Feature label Feb 2, 2024
@Fedik Fedik changed the title [5.1] Use Dialog for scheduler task run [5.1] Use Dialog for scheduler task "Run test" Feb 2, 2024
@fgsw
Copy link

fgsw commented Feb 2, 2024

I have tested this item ✅ successfully on 3cd7dd7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42746.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 3cd7dd7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42746.

@Quy
Copy link
Contributor

Quy commented Feb 2, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42746.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 2, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Feb 2, 2024
@LadySolveig LadySolveig merged commit 08ad334 into joomla:5.1-dev Feb 2, 2024
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 2, 2024
@LadySolveig
Copy link
Contributor

Thank you @Fedik and also for testing @fgsw @viocassel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants