Change center alignment of Joomla! logo on issis login page

[n9iels]

In some languages the alignment of the Joomla! logo on the issis login page isn't in the middle of the page. This is because the translation of Go to site homepage. has more characters in some languages (in dutch for example the translation is: Ga naar de startpagina van de website).
This css and less changes align the logo in the middle of the page regardless the language

[n9iels]

oops, I see the commits of my forked repository are attached to this PR. Is that a problem and how can I prevent this in the future?

[zero-24]

I'm using the Dutch language from here: http://joomlacode.org/gf/download/frsrelease/19702/160147/nl-NL_joomla_lang_full_3.3.3v1.zip

And i can confirm the issue an the patch (also for the german language pack)

Only as note for testers: Clean your cache and/or retry with a alternative Browser if it don't work "out of the box" :D

So @test successful thanks @n9iels

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

[zero-24]

Is that a problem and how can I prevent this in the future?

i don't think this is a problem here. But how you do this change? via Github UI?

If yes you can fork for every issue/PR from the main repo (accessing the file on https://github.com/joomla/joomla-cms and try the edit button) ;)

If you use any tool for git this function calls IIRC anything like "squash the commits". e.g. something like:
http://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits

[n9iels]

Yes, I forked the repo, maked my changes and create a pull request. With the edit function you can't edit multiple files? Or you can?

[zero-24]

With the edit function you can't edit multiple files? Or you can?

yes you can.

1. edit the first time will show you a message like this: http://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests#Fill_in_any_additional_information_in_the_pull_request_including_references_to_an_existing_issue_or_PR. (blue box)
2. there you find a branche name like patch-x
3. you can access your branche at: https://github.com/n9iels/joomla-cms-n9iels/tree/patch-x
4. commit any changes to this branche will update the PR.

Problem: Every change will be a new commit. 😄

[n9iels]

oke, thanks for the explanation :-)
One more test for moving to RTC!

[Bakual]

oops, I see the commits of my forked repository are attached to this PR. Is that a problem and how can I prevent this in the future?

As long as the resulting PR only contains the changes you intended to do, it's absolutely fine 😄
We will usually squash the commits into one anyway.

[infograf768]

Have you tested what it gives for RTL languages?

[n9iels]

I didn't test that, what result you expected? I think it works fine for that languages to. The position:absolute; ensures that the logo stays in the middle, even when the text left and right contains many characters.
I tested that to edit source code with firbug and add some extra text left and right

[infograf768]

Tested: It looks like you have to add the class in template_rtl. less and use generatecss to get it in template_rtl.css with these changes

.login-joomla{
        position: absolute;
        right: 50%;
        height: 24px;
        width: 24px;
        text-indent: -9999px;
        background: url('../images/login-joomla.png') no-repeat;
        margin-right: -12px;
    }

[n9iels]

oops, forget to edit the tempalte_rtl.css and template_rtl.less. But I have no idea how to add that changes to this PR. Can someone explain please?

@infograf768 I think the changes must be made in the .less files, than they can build to .css files. I don't know how to do that on gihub...

[infograf768]

We usually use cli generatecss.php (for the rtl template as well as the LTR one)
we do not do that on github: we do that on our branches and then push into the PR

(also look better at the css I posted above: I changed left to right

[n9iels]

oke that sounds great. but still have no idea how to do that....

[n9iels]

oke after a couple of hours trying and frustrating I run the generatecss.php (I'am sorry for the many changes, something went wrong a couple of times).
@infograf768 I add your class to the template-rtl.less, but when generate the css file this class consist two times. One form the template.less en the second from the template-rtl.less. Is that correct?

[infograf768]

Preparing new PR to replace this one.

[infograf768]

Please test
#4278
It is normal to have the class twice. When adding a class in template_rtl.less it is added at bottom of file, below the import of template.less. Therefore it overrides the one added by template.less

[zero-24]

I am closing this in favour of #4278

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

[jissues-bot]

Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org