Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Minor cleanup for component JS #42778

Merged
merged 30 commits into from Mar 18, 2024
Merged

Conversation

C-Lodder
Copy link
Member

@C-Lodder C-Lodder commented Feb 9, 2024

Summary of Changes

As Joomla no longer supports IE11, this PR mainly removes the need for converting a NodeList to an Array, as evergreen browser's implementation of forEach can iterater over a NodeList.

Also includes some other minor tweaks.

Happy to work on the remaining JS

image

Testing Instructions

Code review @dgrammatiko @Fedik

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Feb 9, 2024
Copy link
Contributor

@dgrammatiko dgrammatiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments about the redundant curly braces.

Great stuff Charlie.

Are you up to also remove the redundant DOMContentLoaded events on the files (almost all) with either defer attribute or type=module?

build/media_source/com_finder/js/finder.es6.js Outdated Show resolved Hide resolved
build/media_source/com_joomlaupdate/js/default.es6.js Outdated Show resolved Hide resolved
build/media_source/com_joomlaupdate/js/default.es6.js Outdated Show resolved Hide resolved
build/media_source/com_joomlaupdate/js/default.es6.js Outdated Show resolved Hide resolved
build/media_source/com_languages/js/overrider.es6.js Outdated Show resolved Hide resolved
build/media_source/com_finder/js/finder-edit.es6.js Outdated Show resolved Hide resolved
C-Lodder and others added 17 commits February 9, 2024 20:05
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
…6.js

Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
…gnment.es6.js

Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
…6.js

Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
…6.js

Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
…6.js

Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
…on.es6.js

Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
@C-Lodder
Copy link
Member Author

C-Lodder commented Feb 9, 2024

@dgrammatiko

Are you up to also remove the redundant DOMContentLoaded events on the files (almost all) with either defer attribute or type=module?

I'll do that in a separate PR, as it will probably involve more than just a code review.

Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
@dgrammatiko
Copy link
Contributor

@C-Lodder can you fix the linter parts? Then I'll give it a test
Screenshot 2024-02-11 at 12 08 46

@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on 29f887d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42778.

@dgrammatiko
Copy link
Contributor

@Fedik could you review this and give it a successful test?

@Fedik
Copy link
Member

Fedik commented Feb 12, 2024

I have tested this item ✅ successfully on 29f887d

Looks good on review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42778.

@Fedik
Copy link
Member

Fedik commented Feb 12, 2024

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42778.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 12, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Feb 26, 2024
@LadySolveig LadySolveig merged commit 9a83a05 into joomla:5.1-dev Mar 18, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 18, 2024
@LadySolveig
Copy link
Contributor

Thank you @C-Lodder and also for review and testing @dgrammatiko @Fedik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants