New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Minor cleanup for component JS #42778
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments about the redundant curly braces.
Great stuff Charlie.
Are you up to also remove the redundant DOMContentLoaded
events on the files (almost all) with either defer
attribute or type=module
?
build/media_source/com_contenthistory/js/admin-compare-compare.es6.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
…6.js Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
…gnment.es6.js Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
…6.js Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
…6.js Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
…6.js Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
…on.es6.js Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
I'll do that in a separate PR, as it will probably involve more than just a code review. |
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
Co-authored-by: Dimitris Grammatikogiannis <dg@dgrammatiko.dev>
@C-Lodder can you fix the linter parts? Then I'll give it a test |
I have tested this item ✅ successfully on 29f887d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42778. |
@Fedik could you review this and give it a successful test? |
I have tested this item ✅ successfully on 29f887d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42778. |
rtc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42778. |
Thank you @C-Lodder and also for review and testing @dgrammatiko @Fedik |
Summary of Changes
As Joomla no longer supports IE11, this PR mainly removes the need for converting a NodeList to an Array, as evergreen browser's implementation of
forEach
can iterater over a NodeList.Also includes some other minor tweaks.
Happy to work on the remaining JS
Testing Instructions
Code review @dgrammatiko @Fedik