Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.2] Other JS improvements #42798

Open
wants to merge 1 commit into
base: 5.2-dev
Choose a base branch
from
Open

[5.2] Other JS improvements #42798

wants to merge 1 commit into from

Conversation

C-Lodder
Copy link
Member

Summary of Changes

  1. Convert site template JS to ES6
  2. Remove [].slice.call() calls where possible.
  3. Other minor improvements

Testing Instructions

  1. Ensure the front-end MetisMenu is working properly.
  2. Code review @dgrammatiko @Fedik

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Feb 12, 2024
@HLeithner
Copy link
Member

@dgrammatiko @Fedik can you have a look?

@HLeithner HLeithner changed the base branch from 5.1-dev to 5.2-dev April 24, 2024 09:07
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.2-dev.

@HLeithner HLeithner changed the title [5.1] Other JS improvements [5.2] Other JS improvements Apr 24, 2024
@Fedik
Copy link
Member

Fedik commented Apr 24, 2024

I have tested this item ✅ successfully on 559efc8

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42798.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev PR-5.2-dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@C-Lodder @HLeithner @Fedik @joomla-cms-bot