Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Trim email before password reset request #42893

Open
wants to merge 1 commit into
base: 4.4-dev
Choose a base branch
from

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Feb 26, 2024

Pull Request for Issue #42374.

Summary of Changes

When typing in the email adress and accidentally adding a space at the front, the process fails. See the original issue linked above.

I read the original issue and I'm not sure if this is a bug or a feature or if we even want to interfer this way with this, but I decided to create a PR anyway, since it is easier to discuss with code directly instead of hypotheticals.

Testing Instructions

Type in your email adress with a space at the beginning.

Actual result BEFORE applying this Pull Request

Password reset fails.

Expected result AFTER applying this Pull Request

Password reset works.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomdonation
Copy link
Contributor

I remember I looked at this issue at PBF but could not replicate it for some reasons. If we want to trim space like this, I think we should add filter="TRIM" to the field, before validate="email" https://github.com/joomla/joomla-cms/blob/4.4-dev/components/com_users/forms/reset_request.xml#L10 instead

@brianteeman
Copy link
Contributor

Personaly this is expected and intended behaviour and should not be accepted

@HLeithner
Copy link
Member

would move it to 5.2, btw. if you already trim the email you could lowercase it too in php but I think it doesn't has an performance impact in sql

@MacJoom MacJoom self-assigned this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants