New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Core loader custom element rework #42903
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
This Pull Request can't be tested by Patchtester
PR-5.1-dev
labels
Feb 27, 2024
Nice one Charlie. Quick question: in the screenshots it seems that the logo is twisted (order of the colours). Was it my fault with the svg? |
@dgrammatiko Good catch, fixed. @Quy Probably not. |
Quy
reviewed
Feb 27, 2024
Co-authored-by: Quy <quy@nomonkeybiz.com>
I have tested this item ✅ successfully on ef94d64 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42903. |
1 similar comment
I have tested this item ✅ successfully on ef94d64 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42903. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42903. |
Thank you @C-Lodder and for review and testing @dgrammatiko @fgsw @Quy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR has three parts:
inline="true"
andsize="xx"
, allowing us to have an inline instance, rather than fullscreen.Why SVG over CSS?
The original CSS version has loads of hardcoded values, meaning scaling became extremely difficult.
Why aren't we observing the
inline
orsize
attributes?Simply because I do not believe they need observing.
Testing Instructions
npm i
Screenshot
Thank you to @dgrammatiko for providing the SVG.