Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Core loader custom element rework #42903

Merged
merged 9 commits into from Mar 13, 2024
Merged

Conversation

C-Lodder
Copy link
Member

@C-Lodder C-Lodder commented Feb 27, 2024

Summary of Changes

This PR has three parts:

  1. The core loader custom element has been rewritten to use an SVG rather than built using CSS.
  2. We can now pass inline="true" and size="xx", allowing us to have an inline instance, rather than fullscreen.
  3. The sample data module now uses the updated core loader, rather than an old animated GIF.

Why SVG over CSS?
The original CSS version has loads of hardcoded values, meaning scaling became extremely difficult.

Why aren't we observing the inline or size attributes?
Simply because I do not believe they need observing.

Testing Instructions

  1. Run npm i
  2. Go to your Joomla backend
  3. Install the sample data

Screenshot

loader2

Thank you to @dgrammatiko for providing the SVG.

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Feb 27, 2024
@Quy
Copy link
Contributor

Quy commented Feb 27, 2024

Would you consider this to be a fix for #31078 #30099?

@dgrammatiko
Copy link
Contributor

Nice one Charlie. Quick question: in the screenshots it seems that the logo is twisted (order of the colours). Was it my fault with the svg?

@Quy Quy mentioned this pull request Feb 27, 2024
4 tasks
@C-Lodder
Copy link
Member Author

C-Lodder commented Feb 27, 2024

@dgrammatiko Good catch, fixed.

@Quy Probably not.

@Quy
Copy link
Contributor

Quy commented Feb 28, 2024

I have tested this item ✅ successfully on ef94d64


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42903.

1 similar comment
@fgsw
Copy link

fgsw commented Feb 28, 2024

I have tested this item ✅ successfully on ef94d64


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42903.

@Quy
Copy link
Contributor

Quy commented Feb 28, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42903.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 28, 2024
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Mar 13, 2024
@LadySolveig LadySolveig merged commit dac9908 into joomla:5.1-dev Mar 13, 2024
1 of 3 checks passed
@LadySolveig
Copy link
Contributor

Thank you @C-Lodder and for review and testing @dgrammatiko @fgsw @Quy

@Quy Quy removed the RTC This Pull Request is Ready To Commit label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants