Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Fix articles categories module bug #42925

Merged
merged 3 commits into from Mar 4, 2024

Conversation

joomdonation
Copy link
Contributor

Pull Request for Issue #42924.

Summary of Changes

Currently, children categories are being displayed multiple times on articles categories module, see #42924 to understand more about the issue. This PR just fixes that wrong behavior.

Testing Instructions

Follow instructions at #42924 to create the module and confirm the issue

Actual result BEFORE applying this Pull Request

Children categories are being displayed multiple times, both at top level and children level

Expected result AFTER applying this Pull Request

Each category will only be displayed one time as expected.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@woluweb
Copy link

woluweb commented Feb 29, 2024

I have tested this item ✅ successfully on 9cbbe59

I have tested this successfully

  • on J4
  • on J5

Txs Tuan!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42925.

@Quy
Copy link
Contributor

Quy commented Feb 29, 2024

I have tested this item ✅ successfully on 9cbbe59


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42925.

@Quy Quy added the bug label Feb 29, 2024
@Quy
Copy link
Contributor

Quy commented Feb 29, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42925.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 29, 2024
@Quy Quy added this to the Joomla! 4.4.4 milestone Feb 29, 2024
@laoneo laoneo merged commit 6023e5c into joomla:4.4-dev Mar 4, 2024
3 checks passed
@laoneo
Copy link
Member

laoneo commented Mar 4, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants