Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten path to global CSS folder #42975

Merged
merged 1 commit into from Mar 7, 2024
Merged

Conversation

RickR2H
Copy link
Member

@RickR2H RickR2H commented Mar 6, 2024

Pull Request for Issue # .

Summary of Changes

The path to the /global CSS folder is unnecessary long. The WebAssetManager recognizes the short path too because the path to the CSS folder known.

Testing Instructions

Check if in the source code before an after this PR if the colors_standard.min.css file is loaded
The path should be: media/templates/site/cassiopeia/css/global/colors_standard.min.css

Actual result BEFORE applying this Pull Request

Everything works

Expected result AFTER applying this Pull Request

Everything works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@hans2103
Copy link
Contributor

hans2103 commented Mar 7, 2024

Failed to try to reproduce the issue using Joomla 5.
Issue in J5 has already been solved.

$wa->registerAndUseStyle($assetColorName, 'global/' . $paramsColorName . '.css');

Apply the solution to J4.4 is a good idea

@hans2103
Copy link
Contributor

hans2103 commented Mar 7, 2024

I have tested this item ✅ successfully on 5893682


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42975.

1 similar comment
@ricardo1709
Copy link
Contributor

I have tested this item ✅ successfully on 5893682


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42975.

@RickR2H
Copy link
Member Author

RickR2H commented Mar 7, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42975.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 7, 2024
@MacJoom MacJoom self-assigned this Mar 7, 2024
@MacJoom MacJoom added this to the Joomla! 4.4.4 milestone Mar 7, 2024
@MacJoom MacJoom merged commit 468fb2d into joomla:4.4-dev Mar 7, 2024
3 of 4 checks passed
@MacJoom
Copy link
Contributor

MacJoom commented Mar 7, 2024

Thank you!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants