Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Style] changes for Joomla 2.5 SQL file #4300

Closed
wants to merge 4 commits into from
Closed

[Code Style] changes for Joomla 2.5 SQL file #4300

wants to merge 4 commits into from

Conversation

shur
Copy link
Contributor

@shur shur commented Sep 18, 2014

If you export a live site's database and compare it to the core joomla.sql you'll see lots of minor differences. This hardens the database examination and shows that joomla.sql contains many code style mistakes.

What I did:

  • Removed the spacing errors;
  • Names for all variables are now of the same case.
  • Database tables are now listed in alphabetical order; <<< changes removed

The last issue caused most of problems, because the tables arrangement in the original joomla.sql is not alphabetical. Many of the tables are listed almost randomly, which makes it difficult to compare your site database with the original joomla.sql.

How to test:
To make sure that my changes are correct you can do the following:

  1. Get an empty database;
    Import the original joomla.sql file;
    Export the current database to the file e.g. joomla-var1.sql

  2. Drop all tables in the database;
    Import my joomla.sql file;
    Export the current database to the file e.g. joomla-var2.sql

  3. Compare joomla-var1.sql and joomla-var2.sql - there shouldn't any differences between them.

@shur shur changed the title Code style changes for Joomla 2.5 SQL file [Code Style] changes for Joomla 2.5 SQL file Sep 18, 2014
All INDEX replaced to KEY, because KEY is normally a synonym for INDEX
@shur shur mentioned this pull request Sep 26, 2014
@shur
Copy link
Contributor Author

shur commented Dec 7, 2014

Updated to Joomla! 2.5.28 RC

Database tables are now listed in alphabetical order;

These changes have been removed to facilitate PR

@brianteeman
Copy link
Contributor

Thanks for working on this. Unfortunately this did not make it into the final release of Joomla 2.5, or it was handled elsewhere, so this is being closed. If you feel this is still a valid issue in Joomla 3 please create a new issue.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4300.

@brianteeman brianteeman closed this Jan 1, 2015
@shur shur deleted the patch-6 branch July 3, 2015 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants