Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Fix fancy-select for Dark Mode #43008

Merged
merged 1 commit into from Mar 12, 2024

Conversation

LadySolveig
Copy link
Contributor

Pull Request for Issue #42221#issuecomment-1989830009.

Summary of Changes

Fix for Fancy-Select with new Dark Mode Switch

Testing Instructions

Apply patch run npm install.
Check the template Atum parameters Dark mode.

Actual result BEFORE applying this Pull Request

311917953-7d0dfbe1-0793-4d4b-b0de-5807c0b24331

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Mar 12, 2024
@LadySolveig LadySolveig changed the title Fix fancy-select for Dark Mode [5.1] Fix fancy-select for Dark Mode Mar 12, 2024
@LadySolveig LadySolveig requested a review from Fedik March 12, 2024 10:30
@Fedik
Copy link
Member

Fedik commented Mar 12, 2024

Thanks! Looks good, I try to test later ;)

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 0644262


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43008.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Mar 12, 2024

I have tested this item ✅ successfully on 0644262


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43008.

@Quy
Copy link
Contributor

Quy commented Mar 12, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43008.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 12, 2024
@bembelimen bembelimen merged commit eb5590d into joomla:5.1-dev Mar 12, 2024
4 checks passed
@bembelimen
Copy link
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 12, 2024
@bembelimen bembelimen added this to the Joomla! 5.1.0 milestone Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants