Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] spinner support for color schemes #43023

Merged
merged 7 commits into from Mar 16, 2024

Conversation

dgrammatiko
Copy link
Contributor

Pull Request for Issue #43014 .

Summary of Changes

  • Add support for dark/light modes

Testing Instructions

Follow the instructions on the linked issue

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Screenshot 2024-03-13 at 23 35 11 Screenshot 2024-03-13 at 23 35 31

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Mar 13, 2024
@dgrammatiko dgrammatiko force-pushed the 5.1-dev-spinner branch 7 times, most recently from 1f24424 to 6f82e26 Compare March 13, 2024 22:56
@brianteeman
Copy link
Contributor

what was wrong with #43018

@dgrammatiko
Copy link
Contributor Author

Your PR is valid and affects one view but doesn't touch the background color of the spinner.
This PR adapts the spinner to the dark/light convention already introduced in another PR. The spinner is used in many places like article edit view if you change a category and there are some custom fields...

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on c9c7ce0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43023.

@Quy
Copy link
Contributor

Quy commented Mar 14, 2024

The logo is big when installing a sample data.

43023-sample-data

@dgrammatiko dgrammatiko force-pushed the 5.1-dev-spinner branch 4 times, most recently from 055f9c2 to 95f388f Compare March 14, 2024 08:57
@Quy
Copy link
Contributor

Quy commented Mar 14, 2024

I have tested this item ✅ successfully on 6a79403

Beautiful! Thank you!!!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43023.

@Quy Quy added this to the Joomla! 5.1.0 milestone Mar 14, 2024
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 6a79403

👌


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43023.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 5.1.0 milestone Mar 14, 2024
@Quy
Copy link
Contributor

Quy commented Mar 14, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43023.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 14, 2024
@bembelimen bembelimen merged commit 83f2388 into joomla:5.1-dev Mar 16, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 16, 2024
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla! 5.1.0 milestone Mar 16, 2024
@dgrammatiko dgrammatiko deleted the 5.1-dev-spinner branch March 16, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants