[4.4] Fix Sample data installation, fix finder helper addContentType null value #43052
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Helper::addContentType() allows null for mime, however $db->quote() does not.
Same as #43051 but for 4.4
Testing Instructions
Use PHP 8+, set error reaporting to Maximum
On clean installation, try install "Blog Sample Data"Run following code (example in index.php of the template):
Actual result BEFORE applying this Pull Request
PHP warning
Deprecated: PDO::quote(): Passing null to parameter 1 ($string) of type string is deprecated
Expected result AFTER applying this Pull Request
No warning
Link to documentations
Please select: