Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Finder: Simplifying the populateState() method of SearchModel #43091

Open
wants to merge 1 commit into
base: 5.1-dev
Choose a base branch
from

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Mar 19, 2024

Pull Request for Issue #43087 .

Summary of Changes

For reasons unobvious to me, we are using the data from the request object in our input object when populating the state of the SearchModel model. This PR changes this to be in line with all other models by simply using the input object.

Testing Instructions

Codereview?

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@growunder
Copy link

Code reviewed, seams ok


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43091.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants