[5.1]Add focus to treeselect [a11y] #43125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the module manager when you open the tree to assign a module to specific menu items it was not possible to navigate to the chevron with a keyboard to open and close the tree. This pr ensures that you can tab to the chevron and press enter to expand or collapse the tree. Don't moan at me for bad js as the original js was written by the person who has asked for this bug fix
joomla-cms-bot
added
NPM Resource Changed
wilsonge
approved these changes
Mar 26, 2024
|
I have tested this item ✅ successfully on 91e75fa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43125. |
1 similar comment
|
I have tested this item ✅ successfully on 91e75fa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43125. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43125. |
|
Thanks @wilsonge |
|
Thankyou!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the module manager when you open the tree to assign a module to specific menu items it was not possible to navigate to the chevron with a keyboard to open and close the tree.
This pr ensures that you can tab to the chevron and press enter to expand or collapse the tree.
Don't moan at me for bad js as the original js was written by the person who has asked for this bug fix
PARTIAL Pull Request for Issue #43068 .
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed