Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] collapsed sidebar menu [a11y] #43137

Merged
merged 7 commits into from Apr 7, 2024
Merged

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Mar 24, 2024

Fixes to display the flyout title on the sidebar manu in both dark and light modes
replacement pr for #43134

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Mar 24, 2024
@Quy
Copy link
Contributor

Quy commented Mar 24, 2024

I have tested this item ✅ successfully on 976880f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43137.

@Quy Quy added this to the Joomla! 5.1.0 milestone Mar 24, 2024
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 976880f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43137.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 5.1.0 milestone Mar 24, 2024
@Quy
Copy link
Contributor

Quy commented Mar 24, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43137.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 24, 2024
@Quy Quy added this to the Joomla! 5.1.0 milestone Mar 24, 2024
@Quy Quy added the a11y Accessibility label Mar 24, 2024
@brianteeman
Copy link
Contributor Author

would be great if this could make it into 5.1 - otherwise the collapsed admin menu is not usable

@bembelimen bembelimen merged commit 2db47e6 into joomla:5.1-dev Apr 7, 2024
0 of 2 checks passed
@bembelimen
Copy link
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 7, 2024
@brianteeman brianteeman deleted the patch-5 branch April 7, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants