[5.1] pixel shift from dark to light #43138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
NPM Resource Changed
|
Thanks for the fix everyone (hug). |
|
I have tested this item ✅ successfully on 8e7b8c7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43138. |
1 similar comment
|
I have tested this item ✅ successfully on 8e7b8c7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43138. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43138. |
4 tasks
|
Thank you @brianteeman and also for testing @Quy @viocassel |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #43029 .
Summary of Changes
remove additional border on header buttons in dark mode
this prevents the layout shift between light/dark templates
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed