Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] GuidedTours: No error when joomla-welcome is missing #43139

Merged
merged 3 commits into from Mar 27, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Mar 24, 2024

Summary of Changes

When an update of Joomla failed and the joomla-welcome guided tour wasn't added to the database, a big warning is displayed at the top of the backend dashboard. This PR adds another check to make sure we loaded anything in the first place before accessing it.

Testing Instructions

  1. Install Joomla
  2. Delete the joomla-welcome from #__guidedtours
  3. Login to the backend.

Actual result BEFORE applying this Pull Request

Big warning at the top of the screen.

Expected result AFTER applying this Pull Request

No warning.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@obuisard
Copy link
Contributor

I have tested this item ✅ successfully on 8036900


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43139.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Mar 24, 2024

I have tested this item ✅ successfully on 8036900


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43139.

@Quy
Copy link
Contributor

Quy commented Mar 24, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43139.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 24, 2024
@Quy Quy added this to the Joomla! 5.1.0 milestone Mar 24, 2024
@LadySolveig LadySolveig merged commit 344d590 into joomla:5.1-dev Mar 27, 2024
2 of 3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 27, 2024
@LadySolveig
Copy link
Contributor

Thank you @Hackwar and also for testing @obuisard and @Quy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants