Guided tours welcome performance #43166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianteeman
reviewed
Mar 27, 2024
administrator/components/com_guidedtours/src/Model/TourModel.php
Outdated
Show resolved
Hide resolved
brianteeman
reviewed
Mar 27, 2024
administrator/components/com_guidedtours/src/Model/TourModel.php
Outdated
Show resolved
Hide resolved
LadySolveig
reviewed
Mar 27, 2024
administrator/components/com_guidedtours/src/Model/TourModel.php
Outdated
Show resolved
Hide resolved
version Co-authored-by: Brian Teeman <brian@teeman.net>
|
Thy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #43153 .
Summary of Changes
Call to a function isAutostart that performs a simple query to avoid the loading of the full tour if autostart is set to 0.
Testing Instructions
Set 'debug system' and 'debug language' to 'Yes'.
Actual result BEFORE applying this Pull Request
Check that you get the same results as stated in issue #43153 when accessing the dashboard.
Expected result AFTER applying this Pull Request
All additional queries (one simple query that gets the autostart value remains) and untranslated language strings are gone from the debug console.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed