[5.1] Fix the build tools

[dgrammatiko]

Pull Request for Issue # .

Summary of Changes

• the JS cssversioning script needs to be aware where is the current cmd
• it needs to respect .min files

Testing Instructions

Run php build/build.php and check the build/tmp/media folder that all the css files with a URL() (ie font awesome) end with something like ?3jhff

Download the package from https://artifacts.joomla.org/drone/joomla/joomla-cms/5.1-dev/43207/downloads/75243/

Extract the files

Check that the file media/templates/administrator/atum/css/vendor/fontawesome-free/fontawesome.css and media/templates/administrator/atum/css/vendor/fontawesome-free/fontawesome..min.css start with @charset "UTF-8";

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

@bembelimen @LadySolveig

[bembelimen]

Thank you, will test it asap.

[HLeithner]

I have tested this item 🔴 unsuccessfully on 79d2df0

Still the same none charset css files

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43207.}

[dgrammatiko]

Still the same none charset css files

My test instructions are wrong, this needs a new tagged version (ie 5.1.0-RC2) with the code of this PR. This is because of this line:

joomla-cms/build/build.php

Line 272 in 896fa4b

system($systemGit . ' archive ' . $remote . ' | tar -x -C ' . $fullpath);

and the fact that the code of this PR is actually git versioned, in sort it's ignored as the script is getting the tools from the tagged git branch...

I have no clue how this could be tested without merging and then tagging another RC...

@HLeithner any ideas?

UPD: well, I'm forcing the replacement of the build folder and it works but maybe not the best approach...

[HLeithner]

can you please revert this copy thing... if we need a tagged version then it's not a problem to test this.

[HLeithner]

I tested the version before with a tagged release and it works, so please remove the copy code and I can merge it.

[dgrammatiko]

Ok,
will revert the php parts later on
done

[LadySolveig]

I have tested this item 🔴 unsuccessfully on 1489989

many thanks for your work so far @dgrammatiko

running php build/build.php still generates the output without charset in the tmp source code subfolder - e.g. build/tmp/1712314537.

The generated packages for a new 5.1 release are therefore still with none charset.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43207.}

[dgrammatiko]

@LadySolveig this is actually expected and it was requested from @HLeithner here: #43207 (comment)

The important part here is explained here: #43207 (comment)

Basically if you want to test this right now you need to manually edit the build.php file according to cb48ff9

In a real release, assuming the PR is already merged, the release leader creates a tag and publish it in the GitHub then everything would work as expected

[LadySolveig]

I have tested this item ✅ successfully on 1489989

many thanks for your work so far @dgrammatiko

running php build/build.php still generates the output without charset in the tmp source code subfolder - e.g. build/tmp/1712314537.

The generated packages for a new 5.1 release are therefore still with none charset.

Thank you again for the explanation. Just tested with a new tag and all works as expected. 💚 🎉 I apologise for not reading the comments carefully enough.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43207.}

[LadySolveig]

Thank you so much for fixing this so quickly. @dgrammatiko