Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Added link class selection to TinyMCE dialog #43260

Merged
merged 16 commits into from Apr 30, 2024

Conversation

RickR2H
Copy link
Member

@RickR2H RickR2H commented Apr 11, 2024

Pull Request for Issue # .

Summary of Changes

Add a class selector to the "create link" dialog. The selected class will be added to the link. This can be very useful in styling links on the website. Adding Bootstrap button classes will convert the link to a button.

Testing Instructions

  • Go to the tinyMCE configuration and op the "Advanced tab"

tinyMCE-config

  • Add some classes to use in the dropdown
  • Open an article and create a link. At the bottom the configured classes can be selected.

tinyMCE-dialog

Actual result BEFORE applying this Pull Request

Adding classed only possible in the source code editor.

Expected result AFTER applying this Pull Request

Classes can be selected in the link dialog.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org: (will be created after merging the PR)

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.1-dev labels Apr 11, 2024
@brianteeman
Copy link
Contributor

works great. I never would have found it on the advanced tab

RickR2H and others added 4 commits April 11, 2024 17:00
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
@RickR2H
Copy link
Member Author

RickR2H commented Apr 11, 2024

works great. I never would have found it on the advanced tab

I could move it to the first "Plugin" tab? Would that be a better option?

@brianteeman
Copy link
Contributor

works great. I never would have found it on the advanced tab

I could move it to the first "Plugin" tab? Would that be a better option?

I would prefer that. It is where I added all the other tinymce customisations in the past

@RickR2H
Copy link
Member Author

RickR2H commented Apr 11, 2024

@brianteeman I added it to the first tab at the bottom. I also removed the description of the single fields and added an overall description.

@brianteeman
Copy link
Contributor

great - please update the description and screenshots in the original post to match

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 0f4bbcb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43260.

@cybersalt
Copy link

I have tested this item ✅ successfully on 96ee302


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43260.

@RickR2H
Copy link
Member Author

RickR2H commented Apr 11, 2024

@brianteeman could you please do one more test? Code is fine now...

@Quy
Copy link
Contributor

Quy commented Apr 11, 2024

@RickR2H Please rebase for v5.2 as this will be considered as a new feature. Only bug fixes will be merged in v5.1. Thank you!

@RickR2H RickR2H changed the base branch from 5.1-dev to 5.2-dev April 11, 2024 22:15
@Quy Quy added PR-5.2-dev and removed PR-5.1-dev labels Apr 11, 2024
@Quy
Copy link
Contributor

Quy commented Apr 11, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43260.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 11, 2024
@Quy
Copy link
Contributor

Quy commented Apr 11, 2024

Restored tests as latest changes are cs only.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43260.

@HLeithner HLeithner changed the title Added link class selection to TinyMCE dialog [5.2] Added link class selection to TinyMCE dialog Apr 24, 2024
@pe7er pe7er self-assigned this Apr 30, 2024
@pe7er pe7er enabled auto-merge (squash) April 30, 2024 08:41
@pe7er pe7er merged commit aaf1236 into joomla:5.2-dev Apr 30, 2024
2 of 3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 30, 2024
@Quy Quy added this to the Joomla! 5.2.0 milestone Apr 30, 2024
@pe7er
Copy link
Contributor

pe7er commented Apr 30, 2024

Thanks @RickR2H !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants