Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] PHP Deprecated: PDO::quote(): Passing null #43288

Merged
merged 4 commits into from
May 11, 2024

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Apr 17, 2024

Pull Request for Issue
PHP Deprecated: PDO::quote(): Passing null
noted while updating from cli

Summary of Changes

the field folder of #__extensions table is not nullable

Testing Instructions

Database Mysql(PDO), Postgresql (PDO)
set error reporting to maximum
go to Joomla Update and check for update
or
from cli run
php cli\joomla.php update:extensions:check
and or
php cli\joomla.php core:check-updates

Actual result BEFORE applying this Pull Request

in the log
image

from cli

image

Expected result AFTER applying this Pull Request

no more deprecation

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@alikon
Copy link
Contributor Author

alikon commented Apr 17, 2024

more investigation needed

@alikon alikon closed this Apr 17, 2024
@alikon alikon deleted the patch-23 branch April 17, 2024 18:45
@alikon alikon restored the patch-23 branch April 18, 2024 08:03
@alikon alikon reopened this Apr 18, 2024
@alikon alikon marked this pull request as draft April 18, 2024 08:03
@alikon alikon marked this pull request as ready for review April 18, 2024 08:26
@Quy
Copy link
Contributor

Quy commented Apr 20, 2024

I have tested this item ✅ successfully on 19bad77


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43288.

@exlemor
Copy link

exlemor commented Apr 21, 2024

I have tested this item ✅ successfully on 19bad77

Hi @alikon,

I switched my installation to MySQL(PDO), and was able to confirm this test successfully.

Thanks,

Emmanuel


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43288.

@Quy
Copy link
Contributor

Quy commented Apr 21, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43288.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 21, 2024
@bembelimen bembelimen merged commit 36331e8 into joomla:5.1-dev May 11, 2024
4 checks passed
@bembelimen
Copy link
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 11, 2024
@bembelimen bembelimen added this to the Joomla! 5.1.1 milestone May 11, 2024
@alikon alikon deleted the patch-23 branch May 11, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants