Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Finder: Indexer Parsers break search result descriptions #4327 #4345

Closed
wants to merge 2 commits into from
Closed

Fix - Finder: Indexer Parsers break search result descriptions #4327 #4345

wants to merge 2 commits into from

Conversation

Kubik-Rubik
Copy link
Member

See discussion here: #4327

How to test?

In the comments you can find a link to a page from where you can copy the article text (view source code and copy&paste). For the second issue just copy the example in the description of the linked entry.

Create two articles with the example content. Enter the content in an article and run the indexer of the smart search component. Then go to the frontend and search for the articles. After applying the patch you should not see parts of the HTML code in the first and no spaces in the second article!

Thank you for reporting @andykirk!

@Kubik-Rubik
Copy link
Member Author

First test in referenced entry: #4327 (comment)

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

@roland-d
Copy link
Contributor

roland-d commented Oct 2, 2014

@Kubik-Rubik: Do you have better test instructions? I can't reproduce it at this moment.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4345.

@roland-d
Copy link
Contributor

roland-d commented Oct 2, 2014

@test: I was able to reproduce the issue and the fix solves both issues mentioned in the original tracker.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4345.

@phproberto phproberto added the RTC This Pull Request is Ready To Commit label Oct 8, 2014
@phproberto phproberto closed this in 88effc7 Oct 8, 2014
phproberto pushed a commit that referenced this pull request Oct 8, 2014
…4327. Fixes #4345

Fix - Finder: Indexer Parsers break search result descriptions #4327
@mbabker mbabker added this to the Joomla! 3.3.7 milestone Oct 10, 2014
rdeutz pushed a commit to rdeutz/joomla-cms that referenced this pull request Oct 24, 2014
…oomla#4327. Fixes joomla#4345

Fix - Finder: Indexer Parsers break search result descriptions joomla#4327
@mbabker mbabker modified the milestones: Joomla! 3.3.7, Joomla! 3.4.0 Nov 22, 2014
@Kubik-Rubik Kubik-Rubik deleted the com_finder-html-parser-fix branch June 20, 2015 18:10
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants