[5.2][RFC] CMSPlugin: DynamicSubscriberInterface as replacement for deprecated registerListeners #43462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
A replacement for deprecated
registerListeners()
(see #43395)Current limitation of SubscriberInterface is that it does not allow to return listeners depend from runtime.
It has own pros and cons. However in CMS it is sometimes need to have a diffrenet listeners depend from the Application type.
I think DynamicSubscriberInterface will be a good for it.
The difference from SubscriberInterface is that it uses non-static method, which allows subscriber to configure listeners depending on runtime. Additionally, it supports callables.
Testing Instructions
Code review.
Check GuidedTours and ScheduleRunner plugins still works.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
References: