Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Media manager thumbnails better try/catch #43468

Merged
merged 3 commits into from
May 16, 2024

Conversation

dgrammatiko
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

The existing try/catch assumes that the class Image could be instantiated given a path. This might throw if avif or webp is not enabled in the GD (ie misconfigured PHP build).
The try/catch now will handle this in a more predictable way (won't break the media manager list view)

Testing Instructions

Code review, or just upload a new file (assume that the thumbs are enabled)

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@LadySolveig @bembelimen this PR is adjacent to #43295 (comment) so please consider merging it. Thanks

@LadySolveig
Copy link
Contributor

I have tested this item ✅ successfully on 07c04b2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43468.

1 similar comment
@Quy
Copy link
Contributor

Quy commented May 15, 2024

I have tested this item ✅ successfully on 07c04b2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43468.

@Quy
Copy link
Contributor

Quy commented May 15, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43468.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 15, 2024
@bembelimen bembelimen merged commit b1b66f3 into joomla:5.1-dev May 16, 2024
3 checks passed
@bembelimen
Copy link
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 16, 2024
@bembelimen bembelimen added this to the Joomla! 5.1.1 milestone May 16, 2024
@dgrammatiko dgrammatiko deleted the patch-2 branch May 16, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants