Email cloak broken when link parameters are not parsed #4354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an email link parameter contains values with characters such as #, ( or ), among others - <a href="mailto:mail@mail.com style="color: #00F">mail@mail.com</a> - only the latter pattern in the _clock function is matched and thus the code becomes broken.
pjmatos
changed the title
|
@test |
|
Thanks, done #4356 |
|
Test: Created an article with content Applied patch and got the following result: Looked at the HTML source code for each, seems like the expected result is returned here. |
mbabker
added a commit
that referenced
this pull request
Sep 29, 2014
Email cloak broken when link parameters are not parsed (backport #4354)
piotr-cz
pushed a commit
to piotr-cz/joomla-cms
that referenced
this pull request
Oct 6, 2014
rdeutz
pushed a commit
to rdeutz/joomla-cms
that referenced
this pull request
Oct 24, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an email link parameter contains values with characters such as #, ( or ), among others -
< a href="mailto:email @ ..." style="color: #00F">email @ ...< /a>
only the latter pattern in the _clock function is matched and thus the code becomes broken.