NSFW - Love thy layout - NSFW #4397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seth Warburton <seth@internet-inspired.com>
This reverts commit 3097b81.
Signed-off-by: Seth Warburton <seth@internet-inspired.com>
Signed-off-by: Seth Warburton <seth@internet-inspired.com>
|
@test unsuccessful. Got a PHP error: |
Signed-off-by: Seth Warburton <seth@internet-inspired.com>
|
Sorry @wilsonge, that should be fixed now. Happy New Year matey :) |
|
This works OK here. |
| <?php endif; ?> | ||
| </dd> | ||
| <?php endif; ?> | ||
| <?php // Todo Not that elegant would be nice to group the params ?> |
There was a problem hiding this comment.
This is just a duplicate with your latest change (sorry be to an arse)
|
Happy new year dude :) |
Signed-off-by: Seth Warburton <seth@internet-inspired.com>
|
Great catch @wilsonge 🙇 |
|
Thanks. |
wilsonge
added a commit
that referenced
this pull request
Mar 20, 2015
Regression: #4397 dropped tags when info block at the bottom
wilsonge
added a commit
that referenced
this pull request
Apr 4, 2015
Regression: #4397 dropped tags when info block at the bottom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give layouts the love they deserve
Layouts are awesome. There's currently a layout for article info-blocks, the definition list, but it is only currently being used in the category blog view. That makes me sad.
This PR standardises com_content views by extending the use of the definition list layout to article and featured article views as well. As intended with layouts this improves readability, maintainability and versatility of views as the article info definition list markup exists now only in one place, not three.
Testing
There should be no observable changes. A useless div that previously existed in the article view is now removed, but that has no affect on rendered views, it was superflous.
Expected result
An improvement in code readability and maintainability.