optimize validation.js performance

[Fedik]

it a try to optimise the Joomla! form rendering with a lot inputs.
validation.js it third slow script after chosen.js and bootstrap.tooltip on the form page,

Here is some graphs.
test made with disabled chosen.js and bootstrap.tooltip on Global configuration page.

Before this fix:

After fix:

As can see difference around 400ms for JFormValidator initialization, at least on my PC in Chrome 😄

How to test.
Apply patch.
Go to global configuration, or other form where a lot inputs, and compare whether all still works and whether it "feels faster" 😉

[anibalsanchez]

@test OK

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4435.}

[zero-24]

@Fedik can you fix the merge conflicts here? I will test after a resync to be sure that nothing is broken 😄 Thanks!

[Fedik]

@zero-24 done 😉

and I added strict mode, so please retest

[zero-24]

Thanks @Fedik

@test successful I can't see any issues with the patch applyed.

and I added strict mode, so please retest
@Fedik do @anibalsanchez also retest or can we move it now to RTC?

[Fedik]

yes, would be good to retest 😉

@anibalsanchez can you please try one more time? 😉

[anibalsanchez]

... hmmm ... I have manually copied the two files... In Global Configuration, I try to save an empty Site Name, it shows the message "Invalid field: Site Name"... Cancel button does not work.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4435.}

[Fedik]

@anibalsanchez I just checked without the patch, and got same result as you,
so I think it is not a regression that made by this pull request ....
looks like you found some bug in global configuration page 😄

[Fedik]

yes it 🐛 on the configuration page,
there test for task == "application.cancel" but must be task == "config.cancel.application" on first look

[zero-24]

@Fedik do you think we should fix this with this pull or should we open a new for this issue?

[dgrammatiko]

@Fedik You are right here: cancel button has <button onclick="Joomla.submitbutton('config.cancel.application')" class="btn btn-small">

and the script we inject is :

    Joomla.submitbutton = function(task)
    {
        if (task == "application.cancel" || document.formvalidator.isValid(document.getElementById("application-form")))
        {
            Joomla.submitform(task, document.getElementById("application-form"));
        }
    };

[Fedik]

@zero-24 I think would be better separate as it is different things .. I can try make another pull with fix, but at evening

[zero-24]

@zero-24 would be better separate as it is different things .. I can try make another pull with fix, but at evening

Thanks moving here to RTC as the other issue will be handled in a seperate PR by @Fedik Thanks to all!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4435.}

[dgrammatiko]

@test success
before time = 1.004 ms

After time = 0.734 ms

[Fedik]

there fix for cancel button #5738