Fix for #4314 Wrong URL when search sub-category by tag if SEF is on

[oneumyvakin]

Steps to reproduce the issue

1. Enable SEF.
2. Create "category1" with ID 1 and alias "alias1"
3. For "category1" create child "category2" with ID 2 and alias "alias2"
4. Create "tag1" and assign it to "category2"
5. Try to search by "tag1"

Expected result

In search result there will be right URL to "category2" like:
/index.php/component/content/category/1-alias1/2-alias2
or
/index.php/component/content/category/2-alias2
or
/index.php/component/content/category/alias1/2-alias2
or
/index.php/component/content/category/2-alias1/2-alias2

Actual result

In search result category2 has a wrong URL which gives 404 error
/index.php/component/content/category/2-alias1/alias2

System information (as much as possible)

Joomla 3.3.3
PHP 5.4

Additional comments

only if SEF is On
only if search by tag

[infograf768]

Did not test, but Code style should be:

            if (!$advanced && count($array))
            {
                $array[0] = (int) $catid . ':' . $array[0];

                if (count($array) > 1)
                {
                    $array[count($array) - 1] = (int) $catid . ':' . $array[count($array) - 1];
                }
            }

[tairedweb]

@test it still said /index.php/alias1?view=form when i turnon SEF :D

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4448.

[oneumyvakin]

@tairedweb I can't get you.

/index.php/alias1?view=form - always gives 403

could you please create separate bug report with exact steps to reproduce?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4448.

[lunguyenhat]

@test It's working for me
@tairedweb I don't see any link as you talked

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4448.

[tairedweb]

@oneumyvakin worked :D

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4448.

[dimitargsg]

@test I also tested this and it seems that the patch is working properly. I was redirected to the correct category when I searched for tag1.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4448.

[AnishaTailored]

@test,
category link is redirected successfully, but when i click on the 'tag1'(index.php/component/tags/tag/2) which displays 'category2' link, when i click on the link(index.php/13-alias1/13-alias2), it give me "404 Article not found" error.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4448.

[haydenyoung]

I'm unable to replicate this problem. I created a search menu item to check this other than that I followed the steps to reproduce.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4448.

[oneumyvakin]

@AnishaVora Yes, I can reproduce this. Start working to fix this.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4448.

[oneumyvakin]

Fix is ready.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4448.

[roland-d]

@Hackwar Is this not something you are also working on?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4448.

[MPompejus]

Added Patch and tried it the Problem still exist.
The ID for categorie 2 will set in the URL one step forward as id for categorie 1
http://127.0.0.1/bugtesting/index.php/component/content/category/79-alias1/alias2
number 79 is mine ID of categorie 2.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4448.}

[kathastaden]

I tested it with Joomla version: 3.4.4-dev development

• SEF is enabled
• Patch was installed successful

1. Created category1 (ID is set by system - mine is 78) with alias1

2. Created category2 (ID is set by system - mine is 79) with alias2 and category1 as the parent

3. Created a tag named tag1

4. Assigned tag1 to category2

5. Searched for tag1 and got this link as a result to category2:
   http://localhost/wpw2/bugtesting/index.php/component/content/category/79-alias1/alias2

6. Still Error 404 - So the test was not successful

[roland-d]

@oneumyvakin Can you follow up on the test results and make the needed changes to your pull request? Thank you.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4448.}

[oneumyvakin]

@roland-d to be clear, i've submitted this bug and patch two years ago for version 3.3.3, and it works for this version, and it was abandoned for the one year, and after the one year, on version 3.4.4, suddenly, fix became not working. This situation is not ok for me. So I've decide to do not contributing to Joomla any more.

[roland-d]

@oneumyvakin Thank you for your response. The behavior you described happens when the same files you changed are changed by someone else. I will close this PR now as we have a new router merged for Joomla 3.6.