Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate path in JLayoutFile #4673

Closed
wants to merge 3 commits into from

Conversation

nicksavov
Copy link
Contributor

Fixes #4097

@wilsonge
Copy link
Contributor

Just cause I'm an ass I really hate to see this function calling in if statements personally. I would much rather see

$this->fullPath = JPath::find($this->includePaths, $rawPath);

if ($this->fullPath)
{
    // Blah Blah Blah.....
}

As it looks cleaner. But as I say just a personal thing. 👍 though

@joomdonation
Copy link
Contributor

👍 @wilsonge

@nicksavov
Copy link
Contributor Author

Done. The commits should be squashed though. I'm guessing a committer does that? Or should I do that on my end?

@infograf768
Copy link
Member

Will do

@nicksavov
Copy link
Contributor Author

Thanks JM!

@infograf768
Copy link
Member

Merged with 20ca941c6c37
thanks

@wilsonge wilsonge deleted the issue-4097 branch October 16, 2014 08:52
@mbabker mbabker added this to the Joomla! 3.3.7 milestone Oct 16, 2014
rdeutz pushed a commit to rdeutz/joomla-cms that referenced this pull request Oct 24, 2014
@mbabker mbabker modified the milestones: Joomla! 3.3.7, Joomla! 3.4.0 Nov 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra path find in JLayoutFile
6 participants