New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't polute the page with useless javascript #4843
Don't polute the page with useless javascript #4843
Conversation
…oomla-cms into Remove_jsscriptcode_isis Conflicts: administrator/templates/isis/index.php
@Bakual is this broken now? |
@dgt41 Yep, looks like you wanted to update your branch with latest staging? But it applied all commits after your own one, which will mess up the branch.
|
Special Character  in Postgres Blog Sample Data
…oomla-cms into Remove_jsscriptcode_isis
@Bakual Is this ok now or do I have to fix it? |
The commits still look a bit funny, but the resulting diff (https://github.com/joomla/joomla-cms/pull/4843/files) looks about correct. So it will work fine. |
@infograf768 JM can you take a look at this one? This actually is a better implementation of #4694 (now everything is done server side so no javascript code is required). It already got one successful test... |
This works.
and further down
this to be consistent in the code style. |
@infograf768 Thanks! It’s a lot better now |
One more test |
test |
Thanks. Merging |
Don't polute the page with useless javascript
This is a quality control patch
When #4694 was committed there were some things done wrong due to
As none of the above exist anymore we don’t need the javascript part as well.
Results
There shouldn’t be any visual or functional changes
Test
Log in to the admin area
Create a new article
Is the joomla icon and the cog icon on the navigation disabled and not functional?
If yes test is successful