Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4838 Correcting error message when viewlevel name already exists #4858

Closed
wants to merge 3 commits into from

Conversation

infograf768
Copy link
Member

See #4838 and #4727

@infograf768
Copy link
Member Author

For an unknown reason (unknown to me...) this works fine except if duplicating the "Guest" viewlevel

@joomdonation
Copy link
Contributor

For an unknown reason (unknown to me...) this works fine except if duplicating the "Guest" viewlevel

Could you please explain more details about it ? This PR fix that issue ? Or we will have to check the issue with "Guest" view level ?

@infograf768
Copy link
Member Author

Apparently, "Guest" is a very special level and it can be duplicated, although this PR clearly prevents it as it checks for the same title in the table.
The issue is that you can also delete/modify that Guest level and that, as far as I know, it is necessary to keep it in Joomla as is by default.

@joomdonation
Copy link
Contributor

Agree that "Guest" is a special access level. However, I think if we delete it by mistake, we can re-create it. Just names it "Guest" and choose the "Guest" group for that access level and it still works?

@Bakual
Copy link
Contributor

Bakual commented Oct 20, 2014

It shouldn't matter if it's a guest viewlevel or not. You should be able to delete it or set a different one as guest without issues. It is just a setting in the user manager options which points to a certain viewlevel.

However I haven't tested if you really can change it ;)

@infograf768
Copy link
Member Author

Hmm, could have been an issue here locally

Please test PR as is with a default Guest

@infograf768
Copy link
Member Author

I confirm: was a corruption on my test site. This should be OK.

@fontanil
Copy link

Trying to add a new level "Guest" : "Save failed with the following error: Level with the name "Guest" already exists." (same message with others previous levels): patch OK for me

@infograf768
Copy link
Member Author

this should go into 3.4-dev

@wilsonge
Copy link
Contributor

@test get sql error showing before when duplicate name. afterwards got language string explaining cause of issue. result successful

@wilsonge
Copy link
Contributor

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4858.

@infograf768 infograf768 added this to the Joomla! 3.4.0 milestone Oct 21, 2014
@infograf768
Copy link
Member Author

Merged into 3.4.0-dev
bbad053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants