New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#4838 Correcting error message when viewlevel name already exists #4858
Conversation
For an unknown reason (unknown to me...) this works fine except if duplicating the "Guest" viewlevel |
Could you please explain more details about it ? This PR fix that issue ? Or we will have to check the issue with "Guest" view level ? |
Apparently, "Guest" is a very special level and it can be duplicated, although this PR clearly prevents it as it checks for the same title in the table. |
Agree that "Guest" is a special access level. However, I think if we delete it by mistake, we can re-create it. Just names it "Guest" and choose the "Guest" group for that access level and it still works? |
It shouldn't matter if it's a guest viewlevel or not. You should be able to delete it or set a different one as guest without issues. It is just a setting in the user manager options which points to a certain viewlevel. However I haven't tested if you really can change it ;) |
Hmm, could have been an issue here locally Please test PR as is with a default Guest |
I confirm: was a corruption on my test site. This should be OK. |
Trying to add a new level "Guest" : "Save failed with the following error: Level with the name "Guest" already exists." (same message with others previous levels): patch OK for me |
this should go into 3.4-dev |
@test get sql error showing before when duplicate name. afterwards got language string explaining cause of issue. result successful |
RTC |
Merged into 3.4.0-dev |
See #4838 and #4727