Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#29997] [Fix] Email Regex corrupted when #685 was merged #4894

Closed
wants to merge 2 commits into from

Conversation

infograf768
Copy link
Member

@infograf768 infograf768 changed the title [Fix] Email Regex corrupted when #685 was merged [#29997] [Fix] Email Regex corrupted when #685 was merged Oct 22, 2014
@infograf768
Copy link
Member Author

Test with a mail of type: myname39997@travel.travel

@Bakual
Copy link
Contributor

Bakual commented Oct 22, 2014

Tested and merged into staging. Thanks!

@anibalsanchez
Copy link
Contributor

@test Ok, but with some observations.

Cases from here: http://blogs.msdn.com/b/testing123/archive/2009/02/05/email-address-test-cases.aspx

** Valid Email address Reason
OK email@domain.com Valid email
OK firstname.lastname@domain.com Email contains dot in the address field
OK email@subdomain.domain.com Email contains dot with subdomain
OK firstname+lastname@domain.com Plus sign is considered valid character
OK email@123.123.123.123 Domain is valid IP address
ERROR email@[123.123.123.123] Square bracket around IP address is considered valid
ERROR "email"@domain.com Quotes around email is considered valid
OK 1234567890@domain.com Digits in address are valid
OK email@domain-one.com Dash in domain name is valid
OK _______@domain.com Underscore in the address field is valid
OK email@domain.name .name is valid Top Level Domain name
OK email@domain.co.jp Dot in Top Level Domain name also considered valid (use co.jp as example here)
OK firstname-lastname@domain.com Dash in address field is valid

** Invalid Email address Reason
OK plainaddress Missing @ sign and domain
OK #@%^%#$@#$@#.com Garbage
OK @domain.com Missing username
OK Joe Smith email@domain.com Encoded html within email is invalid
OK email.domain.com Missing @
OK email@domain@domain.com Two @ sign
OK .email@domain.com Leading dot in address is not allowed
OK email.@domain.com Trailing dot in address is not allowed
ERROR email..email@domain.com Multiple dots
OK あいうえお@domain.com Unicode char as address
OK email@domain.com (Joe Smith) Text followed email is not allowed
OK email@domain Missing top level domain (.com/.net/.org/etc)
OK email@-domain.com Leading dash in front of domain is invalid
ERROR email@domain.web .web is not a valid top level domain
ERROR email@111.222.333.44444 Invalid IP format
OK email@domain..com Multiple dot in the domain portion is invalid

rvbgnu added a commit to rvbgnu/joomla-cms that referenced this pull request Oct 22, 2014
@rvbgnu
Copy link
Contributor

rvbgnu commented Oct 22, 2014

Well, I'm not that good at crafting Regex. What was the expected behaviour? Because I cannot see what are the rules for validating email addresses here. It looks quite flexible.

Current and future new extensions: #4135 (comment)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4894.

@infograf768
Copy link
Member Author

Please see
#4899

@Bakual Bakual added this to the Joomla! 3.3.7 milestone Oct 24, 2014
rvbgnu added a commit to rvbgnu/joomla-cms that referenced this pull request Nov 4, 2014
@mbabker mbabker modified the milestones: Joomla! 3.3.7, Joomla! 3.4.0 Nov 22, 2014
@infograf768 infograf768 deleted the mailregex branch August 6, 2015 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants