Introduce jquery formvalidator for com_finder

[dgrammatiko]

Executive summary

This PR converts the form validation on com_finder to use plain jquery (no mootools call on every form

[smanzi]

@dgt41 It seems to work, but I'm unable (both with/without this PR) to open any children in Content Maps. Link is the same for every "Title" (Type): /administrator/index.php?option=com_finder&view=maps# Searched in Joomla Issues but can't find anything about this. New bug?

I must say that I'm not a big fan of com_finder as it has serious flaws in multilingual environments and I didn't use it since long...

[dgrammatiko]

@smanzi I don’t get any errors here:

Are you still on 3.3.6? Try to get the files of staging repo in your local environment, many things have been fixed the last weeks

[smanzi]

@dgt41 Yeah, no error me too, but I see you have not indexed your content: try to index it, then go back to the "Content Maps" and try to open any map that has has children...

[smanzi]

@dgt41 Just a silly question (I probably should know, but as a matter of fact I don't): I have my GitHub repo locally, but... how do I "Install" it to my local server where I have 3.3.6 installed? Just copy different files? No DB work to do?

[dgrammatiko]

Just overwrite the files, but be careful you might lose installed staff (overwriting a folder in a mac actually replaces the folder 😕 )
Now on the maps I do have indexed all my staff

But the image i posted above is after clicking in Language…
ALWAYS BACKUP!!!!

[smanzi]

@dgt41
No problem syncing under Windows: wonderful "Beyond compare" application! :-)
Now that you have indexed, try clicking Author or Type...

[dgrammatiko]

Works!

[dgrammatiko]

@smanzi Try to go: http://localhost/administrator/index.php?option=com_installer&view=database and fix the db!

[smanzi]

@dgt41 crap! not here... I'll try syncing my installation with staging... :-( tnxs!

What form should I test here, in com_finder?

[dgrammatiko]

In indexed content try: index, purge, statistics
In content maps try to publish unpublish something
and in search filter try to create a new one

[smanzi]

@dgt41 New search filter without title gives warning instead of error, otherwise:

@test success

[smanzi]

@dgt41 OMG, I'll have to fight with JS again! Will try... :-)
I'll wait until your PR has been merged, to not mix things up...

[smanzi]

@dgt41
Actually here in com_finder for a missing field we have this:

while in all other components we have this:

IMHO an error is better than a warning, but the associated text used in com_finder is more approriate, and I think it will be correct to display the "Error:" title: is this something under the control of your form validator or is it responsibility of each component?

[anibalsanchez]

@test success

1. In indexed content try: index, purge, statistics, OK
2. In content maps try to publish unpublish something, OK
3. and in search filter try to create a new one, OK

In the search filter creation, there is a console Javascript error... it may be unrelated with the validator:

sliderfilter.js
ReferenceError: Class is not defined
FinderFilter = new Class({

[dgrammatiko]

@anibalsanchez I am afraid the same error existed before the new code, I tried to sort it out but with no success. This was already broken!

[chrisdavenport]

There is a pre-existing JavaScript error on this screen, reported here: #5018
A fix would be very welcome.

[dgrammatiko]

@roland-d this one got 2 good tests as well. As for the search filter creation bug is solved here: #5099 But on that one the PLT has to decide which of the two proposed solutions will finally merge to the codebase. I think @chrisdavenport is following that bug

[roland-d]

Moving to RTC as we have 3 successful tests.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5045.