Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeMirror 4.8 #5232

Merged
merged 2 commits into from Dec 6, 2014
Merged

Conversation

okonomiyaki3000
Copy link
Contributor

Because there seems to be something wrong over at #5145

@okonomiyaki3000
Copy link
Contributor Author

I think something went wrong with Travis.

@javigomez
Copy link
Contributor

I have checked and the build is still in queue in Travis, I think we need to wait a bit to get reply.

@infograf768
Copy link
Member

It's working OK here.
Not sure about changing the original html files to empty ones.

@okonomiyaki3000
Copy link
Contributor Author

It's fine. They are just examples. Totally unneeded for using CodeMirror. I'm already making several modifications to the distro anyway. Like concatenation and minifying the addons. So it's not like /media/editors/codemirror was ever a straight copy of their distro.

@infograf768
Copy link
Member

If they are no use, I would just delete them. This is part of the general move to delete the index.html files in J!

@okonomiyaki3000
Copy link
Contributor Author

Ah! I wasn't aware there was such a movement. I can definitely remove them.

@zero-24
Copy link
Contributor

zero-24 commented Dec 5, 2014

@test it works still good here thanks @okonomiyaki3000

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5232.

@zero-24
Copy link
Contributor

zero-24 commented Dec 5, 2014

moving to RTC as we have 2 good tests thanks @okonomiyaki3000

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5232.

@brianteeman brianteeman added the RTC This Pull Request is Ready To Commit label Dec 5, 2014
infograf768 added a commit that referenced this pull request Dec 6, 2014
@infograf768 infograf768 merged commit 7adf67a into joomla:staging Dec 6, 2014
@okonomiyaki3000 okonomiyaki3000 deleted the UpdateCodeMirror branch December 8, 2014 02:42
@okonomiyaki3000 okonomiyaki3000 mentioned this pull request Dec 10, 2014
@Bakual Bakual added this to the Joomla! 3.4.0 milestone Dec 11, 2014
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants