Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Module - Uses current URL in the action attribute of the form element #5346

Merged
merged 2 commits into from Dec 11, 2014
Merged

Login Module - Uses current URL in the action attribute of the form element #5346

merged 2 commits into from Dec 11, 2014

Conversation

Kubik-Rubik
Copy link
Member

Description

Problem is described here: #5345

How to test

Try to login and logout on several pages of the Joomla! installation, especially on pages without menu entry (e.g. category of an article without menu entry), all processes should work properly. To see the change, open the source code of such a page and compare the URL in the action attribute of the form.

@wilsonge
Copy link
Contributor

wilsonge commented Dec 8, 2014

Do we actually need an action attribute? It's not compulsory in HTML5 and if we're always sending the user to the same page anyway......?

@infograf768
Copy link
Member

This does not work here when sef is off.

@Kubik-Rubik
Copy link
Member Author

@wilsonge I would use the action attribute for consistency.

@infograf768 What exactly does not work? If SEF is off it should just use the index.php URL as it did before (without query parameters).

@infograf768
Copy link
Member

Before the PR, we would get the full non-sef path when there was a menu item for the page displayed.
Now, we only get an index.php

@Kubik-Rubik
Copy link
Member Author

@infograf768 Okay, got it! It would not have an influence on the functionality. Anyway, changed it to set the action attribute value to the called URL. In this case we actually would not require the action attribute at all (as @wilsonge said) but I would still like to have it in.

@infograf768 infograf768 added this to the Joomla! 3.4.0 milestone Dec 11, 2014
@infograf768
Copy link
Member

Merging, thanks.

infograf768 added a commit that referenced this pull request Dec 11, 2014
Login Module - Uses current URL in the action attribute of the form element
@infograf768 infograf768 merged commit 4511b40 into joomla:staging Dec 11, 2014
@Kubik-Rubik Kubik-Rubik deleted the mod_login-form-action-url branch June 20, 2015 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants