Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminates minor javascript error in toolbar popup button #5420

Merged
merged 1 commit into from Dec 14, 2014
Merged

Eliminates minor javascript error in toolbar popup button #5420

merged 1 commit into from Dec 14, 2014

Conversation

dgrammatiko
Copy link
Contributor

Whenever a modal is render through a toolbar popup button, an error is logged in the browser.

This is due to onClick been set as Url.

This PR changes onclick to value (acceptable option for buttons)

Testing

Apply #5386
There are two javascript errors logged in your browsers console (the second one Joomla.toggleSidebar is solved #5259)
Apply this PR
error should go away

@smanzi
Copy link

smanzi commented Dec 13, 2014

@dgt41 confirmed issues and fixing by respective PRs
@test success

@roland-d
Copy link
Contributor

@test all good and fixes also a JS error on the banner tracks export.

@roland-d
Copy link
Contributor

Moving to RTC, we have 2 successful tests.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5420.

roland-d added a commit that referenced this pull request Dec 14, 2014
Eliminates minor javascript error in toolbar popup button
@roland-d roland-d merged commit bcc487d into joomla:staging Dec 14, 2014
@dgrammatiko dgrammatiko deleted the _toolbar_popup_error branch December 14, 2014 15:19
@rdeutz rdeutz added this to the Joomla! 3.4.0 milestone Feb 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants