Eliminates minor javascript error in toolbar popup button #5420
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a modal is render through a toolbar popup button, an error is logged in the browser.
This is due to
onClick
been set as Url.This PR changes
onclick
to value (acceptable option for buttons)Testing
Apply #5386
There are two javascript errors logged in your browsers console (the second one
Joomla.toggleSidebar
is solved #5259)Apply this PR
error should go away