Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select box in list views on phones #5629

Closed
wants to merge 1 commit into from
Closed

Select box in list views on phones #5629

wants to merge 1 commit into from

Conversation

brianteeman
Copy link
Contributor

The majority of list views do not have a select box for each item. This makes the majority of the toolbar buttons useless and the list view for the new update sites option had no mobile customisation at all.

This PR ensures that all list views have a select box for each item so that all the toolbar buttons work.

To test apply the pull request (it will be easiest if you do this with a test site with the test sample data) and:

  1. ensure that all list views in all components work as before in desktop view - there should be no changes.
  2. ensure that all list views in all components have a select box next to each item in every component view AND a select all checkbox in the column heading.

@zero-24
Copy link
Contributor

zero-24 commented Jan 6, 2015

@brianteeman can you see here: #5627 it does the same but also fix the issues No search button on moblie devices

@brianteeman
Copy link
Contributor Author

Shucks looks like we were committing at the same time. ;) My fault - I said
i didnt have the time.

I will leave it to you to check to see if mine is a complete duplicate or
if I did some extras - my git-fu is not good enough to compare.

Either do a PR against my branch to update it if I missed something or tell
me to close my branch.

On 6 January 2015 at 20:23, zero-24 notifications@github.com wrote:

@brianteeman https://github.com/brianteeman can you see here: #5627
#5627 it does the same but
also fix the issues No search button on moblie devices


Reply to this email directly or view it on GitHub
#5629 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@zero-24
Copy link
Contributor

zero-24 commented Jan 6, 2015

@brianteeman

I think we should close here, as my PR also fix the No search button on moblie devices Issue (also only a hidden on phone issue atm). The missing views (contact & menus/items) i allready applyed to my PR now.

The Updatesites view i would think can go with a seperate PR together or as standalone with referance to #5628

What do you think?

@zero-24
Copy link
Contributor

zero-24 commented Jan 6, 2015

my git-fu is not good enough to compare.

you can see here on github which files are changed. Switch to the Files changed Tab and click Showing 15 changed files 😄

@brianteeman
Copy link
Contributor Author

Seems to make sense to just have one PR.
On 6 Jan 2015 21:04, "zero-24" notifications@github.com wrote:

@brianteeman https://github.com/brianteeman

I think we should close here, as my PR also fix the No search button on
moblie devices Issue (also only a hidden on phone issue atm). The missing
views (contact & menus/items) i allready applyed to my PR now.

The Updatesites view i would think can go with a seperate PR together or
as standalone with referance to #5628
#5628

What do you think?


Reply to this email directly or view it on GitHub
#5629 (comment).

@wilsonge
Copy link
Contributor

wilsonge commented Jan 6, 2015

Closing in favour of Tobias's one as commented then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants