Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break word for disabled functions in the php system info page #5697

Merged
merged 1 commit into from
Jan 15, 2015
Merged

Break word for disabled functions in the php system info page #5697

merged 1 commit into from
Jan 15, 2015

Conversation

brianteeman
Copy link
Contributor

If you have a "crazy" long list of disabled php functions then this can break the layout of the page as there are no spaces in the string.

You can see this in the screenshots #5686

This PR add the class word-break to the td to prevent this happening. To test it I had to manual insert a long list of disabled functions using chrome inspector

@pe7er
Copy link
Contributor

pe7er commented Jan 13, 2015

@test
Patch works good:
The list of Disabled Functions is split over multiple lines.
Clearly visible if you make your browser window smaller.

@waader
Copy link
Contributor

waader commented Jan 14, 2015

@test works!

@brianteeman
Copy link
Contributor Author

Setting RTC - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5697.

@brianteeman brianteeman added the RTC This Pull Request is Ready To Commit label Jan 14, 2015
@rdeutz rdeutz added this to the Joomla! 3.4.0 milestone Jan 15, 2015
rdeutz added a commit that referenced this pull request Jan 15, 2015
Break word for disabled functions in the php system info page

Thanks all :-)
@rdeutz rdeutz merged commit c684bc3 into joomla:staging Jan 15, 2015
@brianteeman brianteeman deleted the sysinfoword-break branch January 15, 2015 21:51
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants