Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding language string Alternative Layout dropdown #5742

Merged
merged 1 commit into from
Jan 15, 2015
Merged

Adding language string Alternative Layout dropdown #5742

merged 1 commit into from
Jan 15, 2015

Conversation

pe7er
Copy link
Contributor

@pe7er pe7er commented Jan 15, 2015

See Extensions > Module Manager > Smart Search Module > [Advanced] settings
Alternative Layout displays "default" instead of "Default" because language string was missing.

See Extensions > Module Manager > Smart Search Module > [Advanced] settings
Alternative Layout displays "default" instead of "Default" because language string was missing.
@pe7er
Copy link
Contributor Author

pe7er commented Jan 15, 2015

module manager module smart search module
This patch changes the dropdown label "default" to "Default".

@waader
Copy link
Contributor

waader commented Jan 15, 2015

@test works!

@brianteeman
Copy link
Contributor

Please dont commit this. It is already addressed in the big engb patch that
will be committed after language freeze
On 15 Jan 2015 20:27, "waader" notifications@github.com wrote:

@test https://github.com/test works!


Reply to this email directly or view it on GitHub
#5742 (comment).

@brianteeman
Copy link
Contributor

Correction - didn't realise it was a new string. Can be committed if needed. For reference all the other occurrences of lower case default have been capitalised in the en-gb mega patch


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5742.

@zero-24
Copy link
Contributor

zero-24 commented Jan 15, 2015

@test success moving to RTC Thanks for your tests and the code!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5742.

@brianteeman brianteeman added the RTC This Pull Request is Ready To Commit label Jan 15, 2015
@rdeutz rdeutz added this to the Joomla! 3.4.0 milestone Jan 15, 2015
rdeutz added a commit that referenced this pull request Jan 15, 2015
Adding language string Alternative Layout dropdown

Thanks all :-)
@rdeutz rdeutz merged commit d3cb3bc into joomla:staging Jan 15, 2015
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Oct 14, 2015
@pe7er pe7er deleted the patch-4 branch November 5, 2015 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants