Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imp] avoid to open div and closing it in different files #6134

Closed
wants to merge 1 commit into from
Closed

[imp] avoid to open div and closing it in different files #6134

wants to merge 1 commit into from

Conversation

phproberto
Copy link
Contributor

In the catefories view the parent div was created in a layout. That's a bad practice that can cause unexpected issues when overriding views.

Test

Ensure that all the categories views are showed correctly. The PR includes articles, newsfeeds & contact categories because they were the only calling that layout but if you find more test it there please. Also in the menu item of each category view add a "Page class" in the "Page display" tab and ensure that is applied correctly.

Backward compatibility issues

This should only cause issues if someone is already using that layout. In that case they may have created a a dirty fix to close the orphan div. But this is a bug so we should fix it.

@ghost
Copy link

ghost commented Mar 10, 2015

@test Success

@continga
Copy link

Test OK

@brianteeman brianteeman added the RTC This Pull Request is Ready To Commit label Mar 14, 2015
@brianteeman
Copy link
Contributor

Thanks for testing - RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6134.

@phproberto phproberto added this to the Joomla! 3.4.1 milestone Mar 15, 2015
@phproberto
Copy link
Contributor Author

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants