Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Languages: Prevent saving an incorrect language tag when saving a Content Language #6138

Merged
merged 1 commit into from Feb 25, 2015

Conversation

infograf768
Copy link
Member

Create a Content Language. You can save an incorrectly formatted Language Tag, i.e. a tag which does not obey to the simple rule:
2 or 3 lowercase letters + dash + 2 Uppercase letters
Example: fr-FR, ckb-IQ, etc.
The field accepts anything....

This patch throws an error when the format is wrong.
After applying, try to save anything different from the rule above.

For 3.4.1

@Fedik
Copy link
Member

Fedik commented Feb 21, 2015

test
works good,
now I do not able to save blabla 😄

@Hils
Copy link
Contributor

Hils commented Feb 21, 2015

@test
Confirm that, after adding patch, unable to save fvfvfv (an incorrect ISO Country code).
(3.4.0 RC1)

@zero-24
Copy link
Contributor

zero-24 commented Feb 21, 2015

RTC based on testing. Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6138.

@infograf768 infograf768 added the RTC This Pull Request is Ready To Commit label Feb 22, 2015
wilsonge added a commit that referenced this pull request Feb 25, 2015
Content Languages: Prevent saving an incorrect language tag when saving a Content Language
@wilsonge wilsonge merged commit 958e823 into joomla:staging Feb 25, 2015
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
@infograf768 infograf768 deleted the lang_tag_error branch November 12, 2015 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants