Fix for Codemirror Cant Type Forward Slash

[PhilETaylor]

This PR applies an upstream bug fix to CodeMirror
see: codemirror/codemirror5@076afcb14e8be6

Steps to reproduce the issue

Set Codemirror as default editor.
Either create a new article or edit an existing article.
Type a forward slash ( / ) in the editor window.

Expected result

A forward slash appears in the editor window

What happens

No slash....

To test this PR

Apply patch - set CodeMirror as active editor see if you can type a slash in editor window

Closes #6277
Closes #6181

[brianteeman]

Is this issue in an external library or our implementation of it?
If it is in the codemirror code then we shouldnt be touching it and should
instead just report upstream

On 3 March 2015 at 16:55, Phil Taylor notifications@github.com wrote:

This PR applies an upstream bug fix to CodeMirror
Steps to reproduce the issue

Set Codemirror as default editor.
Either create a new article or edit an existing article.
Type a forward slash ( / ) in the editor window.
Expected result

A forward slash appears in the editor window
What happens

No slash....
To test this PR

Apply patch - set CodeMirror as active editor see if you can type a slash
in editor window

Closes #6277 #6277

Closes #6181 #6181

You can view, comment on, or merge this pull request online at:

#6280
Commit Summary

• Fix for Codemirror Cant Type Forward Slash

File Changes

• M media/editors/codemirror/addon/edit/closetag.js
  https://github.com/joomla/joomla-cms/pull/6280/files#diff-0 (2)

Patch Links:

• https://github.com/joomla/joomla-cms/pull/6280.patch
• https://github.com/joomla/joomla-cms/pull/6280.diff

—
Reply to this email directly or view it on GitHub
#6280.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

[n9iels]

@test confirmed, but the patch doesn't solve the issue for me.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6280.}

[brianteeman]

Please see #6150
On 3 Mar 2015 17:06, "Phil Taylor" notifications@github.com wrote:

Ok I have now upgraded CodeMirror to 5.0.0 released 11 days ago in this PR
for testing - this includes all upstream bugfixes

—
Reply to this email directly or view it on GitHub
#6280 (comment).

[n9iels]

I'm not able to test this patch via the Pacht tester component. When I apply I get a white screen. Not sure if this is a problem with my localhost or the patch..

[n9iels]

The PR brian mentioned is planned for Joomla! 3.5.0 (am I right?).
Should be nice if you can find a fix for this problem for Joomla! 3.4.1, because it is a very irritating bug. Things like typing a css path are impossible now.

[wilsonge]

As we already have a open PR upgrading to Codemirror 5 (#6150) may I suggest we focus efforts there. If you want to test that it would be hugely appreciated :)