Update FOF to version 2.4.2 #6389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
File permissions again :D |
|
No, not the !?#$%^&*()!! permissions again… It’s becoming sort of a running gag with my PRs. OK, fixed now. |
| @@ -846,6 +848,7 @@ protected function bugfixCantBuildAdminMenus() | |||
| } | |||
| } | |||
| } | |||
| /**/ | |||
There was a problem hiding this comment.
I don't know exactly what's going on. But github REALLY hates what you've got going on here. I think it's because of the extra slash before the closing comment here?
There was a problem hiding this comment.
@wilsonge This was just a fancy way to comment out things. But hey, GitHub was unhappy and that code’s redundant so off with its head! Fixed, I guess.
There was a problem hiding this comment.
It does the same thing in the FOF repo FYI. But ty. It's not a big deal I guess as long as the code works but thanks for fixing it!!
There was a problem hiding this comment.
The code works fine. It’s just driving GitHub’s PHP parser nuts because it’s an edge case of PHP’s commenting syntax :)
|
Thanks so much for this @nikosdion :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @wilsonge request, here's the PR to update FOF to version 2.4.2 with improved support for Joomla! 3.4