Checking if the lang_code was already set in POST

[Hackwar]

If Joomla is requested via POST, we might have already a language defined via the URL and thus don't need to fall back on the cookie value.

Example:
Request via POST to "index.php" => No language given, falling back to cookie or default language
Request via POST to "index.php?lang=en" => Language given, no need to fall back to something else
Request via POST to "/en/component/content/42" => Language given, no need to fall back to something else

Without this path, the last 2 examples will fall back to the default language.

[aruttkamp]

tested - ok

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6400.}

[zero-24]

RTC based on testing by @aruttkamp and @kolvar Thanks

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6400.}

[infograf768]

let's wait the cookie issue is solved to look at this one again.

[Hackwar]

Why? Should we stop looking at issues in JForm, too, because of the cookie issue? Those 2 are completely different topics.

[infograf768]

they may be, but it is likely that the languagefilter code will be changed in an important way to solve the cookie issue. Therefore this would have, if still necessary, to be adapted.

[Hackwar]

The proposal by @Bakual does not touch this code.

[Bakual]

What I wonder is if the whole if clause makes sense. The comment says we don't care about language, but we actually do care now. Or am I wrong?

[gwsdesk]

@test works4me . I cannot judge if sense or not. The tests of PR by Bakual were successful (2/3 tests). I tested this now with #6452 installed and this still works4me

[Hackwar]

The comment might have to be adapted.

[Kubik-Rubik]

Works as described, thanks @Hackwar!

[ghost]

The $lang_code could be not initialised in your check yet.
So shouldn't it be:

if (!isset($lang_code))

[Kubik-Rubik]

@nonumber Thank you for the catch, fixed with: #6458