Add tests for JLanguageMultilang #6443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Get application object if not injected. | ||
| if (!$app) | ||
| { | ||
| $app = JFactory::getApplication(); |
There was a problem hiding this comment.
This one will not be tested if you always hand over a $app in the tests. Thus not 100% coverage. 😉
|
Looks good. This test brings up 2 issues for me: JLanguageMultilang couples a multi-lang implementation to our language filter plugin and it shows that our language implementation is pretty hacked together... This class is pretty much just bloat. A proper implementation would read that from some general storage and a proper languagefilter implementation would set that flag regardless of the app that is currently running. |
|
Replaced by #6479 which removes the application injection |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a small change to allow the application object to be injected in to allow unit tests this can be tested easily by just navigating around Joomla.
Finally as per the doc block I've typecast the result to be a boolean as it was returning the string 0 on false and 1 on true for the enabled state of the plugin (as these are the values stored in the database). Currently you get true and false in the frontend and 0 and 1 in the backend.
Testing
All the routing in the frontend depends on this class so navigate around and ensure that with plugin enabled and disabled everything works as expected.
In the backend ensure that the modal views when you are selecting a single item in the menu show everything properly